Skip to content

Fix typo in markdown_parser doc comment#9341

Merged
captainsafia merged 2 commits into
warpdotdev:masterfrom
anshul-garg27:fix/doc-comment-typos
Apr 30, 2026
Merged

Fix typo in markdown_parser doc comment#9341
captainsafia merged 2 commits into
warpdotdev:masterfrom
anshul-garg27:fix/doc-comment-typos

Conversation

@anshul-garg27
Copy link
Copy Markdown
Contributor

Description

Fixes a typo in the process_emphasis doc comment in crates/markdown_parser/src/markdown_parser.rs: performaceperformance.

Testing

Doc-comment-only change.

@cla-bot cla-bot Bot added the cla-signed label Apr 28, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Apr 28, 2026

@anshul-garg27

I'm starting a first review of this pull request.

You can follow along in the session on Warp.

I approved this pull request and requested human review from: @vorporeal, @alokedesai, @zachbai.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Apr 28, 2026

@anshul-garg27

I'm checking this implementation PR for association with a likely matching ready issue.

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR fixes a typo in the process_emphasis doc comment in crates/markdown_parser/src/markdown_parser.rs.

Concerns

  • No correctness, security, error-handling, or performance concerns found.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@anshul-garg27
Copy link
Copy Markdown
Contributor Author

The Windows test failures here look like flaky timeouts unrelated to this change — this PR only touches a single typo (performaceperformance) in a doc comment in crates/markdown_parser/src/markdown_parser.rs. The failing tests are 60-second timeouts on tests like completer::tests::test_session_context_top_level_commands_includes_external_commands, drive::index::tests::test_retry_menu_item_*, and several notebooks::editor mermaid tests, none of which exercise any code path touched here.

Could a maintainer kick off a re-run? Happy to also rebase on master if that helps.

@captainsafia
Copy link
Copy Markdown
Contributor

@anshul-garg27 Kicked of a re-run for you here.

@captainsafia captainsafia merged commit 150df7e into warpdotdev:master Apr 30, 2026
50 of 52 checks passed
@captainsafia captainsafia added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Apr 30, 2026 — with Warp Dev Github Integration
zerx-lab pushed a commit to zerx-lab/zap that referenced this pull request May 3, 2026
## Description

Fixes a typo in the `process_emphasis` doc comment in
`crates/markdown_parser/src/markdown_parser.rs`: `performace` →
`performance`.

## Testing

Doc-comment-only change.

Co-authored-by: anshul-garg27 <anshul-garg27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants