Replace deprecated apt-key with gpg --dearmor for gcloud install#9538
Merged
vorporeal merged 1 commit intowarpdotdev:masterfrom Apr 30, 2026
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @vorporeal. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR replaces the deprecated apt-key call in the Linux test dependency installer with gpg --dearmor, allowing Google Cloud SDK apt key setup to work on newer Debian/Ubuntu releases where apt-key is unavailable.
Concerns
- No blocking concerns found in the changed line.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
vorporeal
approved these changes
Apr 30, 2026
captainsafia
added
the
external-contributor
Warp Dev Github Integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9534.
script/linux/install_test_deps:32registered Google Cloud SDK's aptsigning key via
apt-key, which was removed fromaptin 2.9.17(2024-12) and is no longer present on Ubuntu 25.04+ and
Debian 13+. On those distros
script/linux/bootstrapfailed for anycontributor who didn't already have
gcloudinstalled, with a confusingsudo: 'apt-key': command not found/curl: Failed writing bodypair.Replaced the
apt-keyinvocation withgpg --dearmor, which is thedocumented replacement and works on every Debian-family release back to
Debian 9 / Ubuntu 16.04 — the same lower bound that the existing
signed-by=/usr/share/keyrings/cloud.google.gpgdirective on the nextline already imposes. Also switched
curl -ftocurl -fsSL, thestandard quiet-but-fail-on-error flag set, and added
--yesso a stalekeyring left from a partial previous bootstrap is overwritten cleanly.
This is a strict superset of the previous behavior — it works everywhere
the old command worked and additionally on apt 3.0+ where
apt-keyisgone.
Testing
Manually ran the patched line on Ubuntu 25.10 (apt 3.1.6, no
apt-keybinary): it produces
/usr/share/keyrings/cloud.google.gpgand thesubsequent
apt-get update/apt-get install google-cloud-clisucceed. Re-ran a second time to confirm
--yesoverwrites the existingkeyring without prompting. No automated regression test added — this is
a one-line bootstrap script change whose failure mode is environmental
(absence of
apt-keyon the host) and CI runs on a distro where thebug doesn't reproduce.
Server API dependencies
No server API dependencies.
Agent Mode
CHANGELOG-BUG-FIX:
Co-Authored-By: Warp agent@warp.dev