Add FAQ documentation for contributors and users#9591
Add FAQ documentation for contributors and users#9591warp-repo-sync[bot] wants to merge 1 commit intomasterfrom
Conversation
Repo-Sync-Origin: warpdotdev/warp-internal@11edee2
|
Assigning to @app/warp-repo-sync-approval to review/resolve sync conflict. |
|
@warp-repo-sync[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and posted feedback on this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds FAQ documentation, but the diff leaves unresolved merge conflict markers in FAQ.md.
Concerns
FAQ.mdcontains committed conflict markers around the FAQ section about using Codex or Claude models in Warp, which will render broken documentation until resolved.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
|
||
| Yes. Use whatever you like — Warp's built-in agent, Claude Code, Codex, Gemini CLI, Cursor, others, or no agent at all. The repo ships agent-readable context (skills under [`.agents/skills/`](.agents/skills/), specs under [`specs/`](specs/), and [`WARP.md`](WARP.md)) that any harness supporting these formats can pick up. | ||
|
|
||
| <<<<<<< HEAD |
There was a problem hiding this comment.
## Description `get_pr_for_commit()` was silently catching `CalledProcessError` and returning `None` on GitHub API failures. The loop detection code in `is_sync_originated()` treated this the same as "no PR found," causing it to fail-open: sync-originated commits were not filtered out, and the sync workflow created reverse-direction PRs that should never have existed. This was the root cause of warpdotdev/warp#9591 (and 3 other PRs created on 2026-04-30), where public→private sync commits were synced back to public. The fix removes the blanket `except` from `get_pr_for_commit()` so API errors propagate. In the loop detection path this aborts the sync run; in non-critical call sites (PR description building, reviewer lookup) the callers now catch and degrade gracefully with logging. ## Testing Added `test_api_failure_propagates_when_trailer_present` to verify that `is_sync_originated` raises on API failure instead of returning `False`. All existing loop detection tests continue to pass. Co-Authored-By: Oz <oz-agent@warp.dev>
1 participant
Adds a comprehensive FAQ document covering contributing to the Warp client, working with agents in the repository, licensing, and the relationship between open-source and proprietary components. The FAQ clarifies contribution workflows, issue readiness labels, spec PR requirements, agent usage, collaboration roles, licensing choices (AGPL for the client, MIT for UI frameworks), and security reporting procedures.
Repo-Sync-Origin: warpdotdev/warp-internal@11edee28433c4087a3422c8db20c408c897e6df3
Repo-Sync-Conflict: cherry-pick
Repo-Sync-Assigned: app/warp-repo-sync-approval@2026-04-30T13:35:27Z