spec: add Kiro CLI agent integration spec for GH#9066#9858
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @rarean on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds product and technical specs for making Kiro CLI a first-class CLI agent and ignores local Kiro/artifact directories.
Concerns
- The technical spec proposes an executable
curl | bashinstall command in Warp's plugin instructions UI, which would encourage running a remote script through the terminal from the product. - The settings-page implementation guidance points at a file that does not exist and does not account for the current settings UI's lack of per-agent documentation links.
- The feature-flag guidance only gates command detection, but adding a
CLIAgentenum variant also exposes it through enum-iteration consumers such as settings dropdowns unless those surfaces are gated too.
Security
- The proposed executable installer command should be replaced with link-only guidance or a non-executable, verifiable installation path before the spec is used for implementation.
Verdict
Found: 0 critical, 3 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
This PR adds product and technical specs for making Kiro CLI a first-class CLI agent and ignores local Kiro/artifact directories.
Concerns
- The technical spec proposes an executable
curl | bashinstall command in Warp's plugin instructions UI, which would encourage running a remote script through the terminal from the product. - The settings-page implementation guidance points at a file that does not exist and does not account for the current settings UI's lack of per-agent documentation links.
- The feature-flag guidance only gates command detection, but adding a
CLIAgentenum variant also exposes it through enum-iteration consumers such as settings dropdowns unless those surfaces are gated too.
Security
- The proposed executable installer command should be replaced with link-only guidance or a non-executable, verifiable installation path before the spec is used for implementation.
Verdict
Found: 0 critical, 3 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds product and tech specs for Kiro CLI as a first-class CLI agent, plus ignores local .artifacts/ and .kiro/ directories.
Concerns
- The product spec requires a settings entry with a documentation link, while the tech spec says the current settings UI has no per-agent documentation link and needs no explicit settings change.
- The proposed Kiro plugin instructions only install/verify the Kiro CLI, not the Warp plugin/event protocol required for real-time status tracking.
- The product spec promises update instructions, but the proposed plugin manager disables update support and returns empty update instructions.
- The final plugin-manager factory snippet conflicts with the earlier feature-flag gating guidance and does not match the current Option-returning factory signature.
- Security pass: no security-specific issues were identified in this documentation-only diff.
Verdict
Found: 0 critical, 4 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds product and technical specs for integrating Kiro CLI as a first-class CLI agent, plus ignore rules for local artifacts and Kiro configuration.
Concerns
- The product spec's remote-session behavior conflicts with both the degraded-mode behavior and the current/technical plan for showing plugin instructions.
- The technical spec's plugin-manager guard omits the global HOA notifications kill switch used by existing notification plugin managers.
- The proposed Kiro plugin manager claims update support without specifying installation/version detection needed for the local outdated-plugin flow.
- Security pass found no changed executable code paths, new dependencies, or committed secrets.
Verdict
Found: 0 critical, 3 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds product and technical specs for first-class Kiro CLI agent support plus ignores local Kiro/artifact directories.
Concerns
- The tech spec does not gate persisted custom-command mappings, so a saved
Kiroassignment can still activate the hidden agent whileFeatureFlag::KiroCLIAgentis disabled. - The remote-session behavior says plugin install/update instructions are not shown, but the current generic CLI-agent footer code intentionally shows manual install instructions for remote sessions.
- The product spec requires update instructions for outdated plugins, while the tech spec disables update support and returns empty update instructions.
- The proposed install instructions are not concrete enough to render an actionable in-app plugin pane.
Verdict
Found: 0 critical, 3 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
/oz-review |
|
This PR is not linked to an issue that is marked with Issue-state enforcement details:
To continue, link this PR to a same-repo issue such as Powered by Oz |
There was a problem hiding this comment.
This PR is not linked to an issue that is marked with ready-to-implement.
Issue-state enforcement details:
-
Associated same-repo issues checked: none
-
Required readiness label:
ready-to-implement
To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.
Powered by Oz
rarean
force-pushed
the
spec/9066-kiro-cli
branch
from
01175b4 to
b8a63d2
Compare
|
/oz-review |
There was a problem hiding this comment.
This PR is not linked to an issue that is marked with ready-to-implement.
Issue-state enforcement details:
-
Associated same-repo issues checked: none
-
Required readiness label:
ready-to-implement
To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.
Powered by Oz
Add product and tech specs for supporting Kiro CLI as a first-class CLI agent in Warp, alongside Claude Code, Codex, Gemini, and others. Issue is labeled ready-to-spec: warpdotdev#9066 specs/GH9066/product.md — 13 behavior invariants covering: - Command detection and Kiro-branded footer - Rich input composer (Ctrl-G) and prompt submission via PTY - Plugin install/update instructions pane - Real-time session status tracking (InProgress/Blocked/Success) - Settings page entry, telemetry, shared session serialization - Graceful degradation when plugin is not installed specs/GH9066/tech.md — 5 concrete code changes: - CLIAgent::Kiro variant + all exhaustive match arms (cli_agent.rs) - Icon::KiroLogo + brand color constant (icons.rs + assets/) - CLIAgentType::Kiro telemetry variant (events.rs) - FeatureFlag::KiroCLIAgent gating in DOGFOOD_FLAGS (features.rs) - KiroPluginManager + kiro.rs + kiro_tests.rs (plugin_manager/) Also adds .kiro/ to .gitignore. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rarean
force-pushed
the
spec/9066-kiro-cli
branch
from
b8a63d2 to
6801263
Compare
|
/oz-review |
There was a problem hiding this comment.
This PR is not linked to an issue that is marked with ready-to-implement.
Issue-state enforcement details:
-
Associated same-repo issues checked: none
-
Required readiness label:
ready-to-implement
To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.
Powered by Oz
1 participant
Description
Add product and tech specs for supporting Kiro CLI as a first-class CLI agent in Warp, alongside Claude Code, Codex, Gemini, and others.
Linked Issue
ready-to-specorready-to-implement.Issue is labeled ready-to-spec:
Support Kiro CLI Agent Integration in Warp #9066
What's Included
specs/GH9066/product.md — 13 behavior invariants covering:
specs/GH9066/tech.md — 5 concrete code changes:
Also adds .kiro/ to .gitignore.
Testing
Agent Mode
CHANGELOG-IMPROVEMENT: Kiro CLI as a first-class CLI agent in Warp