Merged
Conversation
alokedesai
reviewed
Sep 30, 2022
Member
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
Thanks for contributing! Just a few small comments to clarify my understanding!
alokedesai
reviewed
Sep 30, 2022
Member
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
One more comment! Besides that, it should be good to go :)
alokedesai
reviewed
Sep 30, 2022
alokedesai
approved these changes
Sep 30, 2022
Member
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
LGTM! Thank you for contributing!
Contributor
Author
|
@alokedesai Would you please add the `hacktoberfest-approved' label. Thank You |
Member
|
@WebRuin Happy to add that label, but I believe we also need to opt-in the repo for hacktoberfest as well. Please correct me if I'm wrong |
Member
|
Hey @WebRuin! Sorry for the late followup. Would you mind addressing any of the in-flight comments, would love to get all of these amazing workflows merged 🚢 Thanks again! |
elviskahoro
pushed a commit
that referenced
this pull request
Sep 5, 2023
* NPM Workflows * github ssh * npm updates * npm fix * github * github --------- Co-authored-by: Tim Smith <69870077+timscodebase@users.noreply.github.com> Co-authored-by: elvis kahoro <elvis@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord username (optional) please include so we can attribute you with our Contributor role (like so elvis#4747)
Tithos
Description of changes (updated or new workflows)
I added a few NPM workflows for managing node_modules folders.