Add description field to Workflow constructor#157
Merged
Conversation
alokedesai
reviewed
Apr 24, 2023
| command: command.into(), | ||
| tags: vec![], | ||
| description: None, | ||
| description, |
Member
There was a problem hiding this comment.
thoughts on setting this via a builder pattern instead?
fn with_description(mut self, description: String) -> Self {
}Passing this through the constructor can be a little awkward if majority of the time it will be just None (in which case it's not clear what the description even is). This also matches the API for setting the arguments
Contributor
Author
There was a problem hiding this comment.
Totally see that reasoning - will make the change!
alokedesai
approved these changes
Apr 24, 2023
| self | ||
| } | ||
|
|
||
| pub fn with_description(mut self, description: String) -> Self { |
Member
There was a problem hiding this comment.
nit: you shouldn't need a clone here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes (updated or new workflows)
Adds a description field to the Workflow constructor. Previously it was hardcoded to
None, this allows it to be set when callingWorkflow::new().