Skip to content

Add “Open a path in VS Code”#163

Merged
elviskahoro merged 4 commits intowarpdotdev:mainfrom
pan93412:specs/vs-code
Sep 5, 2023
Merged

Add “Open a path in VS Code”#163
elviskahoro merged 4 commits intowarpdotdev:mainfrom
pan93412:specs/vs-code

Conversation

@pan93412
Copy link
Copy Markdown
Contributor

@pan93412 pan93412 commented Jun 3, 2023

Discord username (optional) please include so we can attribute you with our Contributor role (like so elvis#4747)

pan93412#7826

Description of changes (updated or new workflows)

Add “Open a path in VS Code”

Although it is largely duplicated to “Open a file or directory in the currently open VS Code window”, this workflow is still valuable because:

  • It uses . as the default dir, which is more common in development.
  • It does not add any additional flags such as -r.

Although it is largely duplicated to “Open a file or directory
in the currently open VS Code window”, this workflow is still
valuable because:

- It uses `.` as the default `dir`, which is more common in
  development.
- It does not add any additional flags such as `-r`.

Signed-off-by: pan93412 <pan93412@gmail.com>
@alfawal
Copy link
Copy Markdown

alfawal commented Aug 4, 2023

I think adding --new-window here is a good idea. Because most of the time if you want to open a new single file, you don't want it to be opened in the current workspace.

Alternatively, we can add another workflow called "Open a path in VS Code - New Window".

Copy link
Copy Markdown

@elviskahoro elviskahoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @pan93412

@elviskahoro elviskahoro enabled auto-merge (squash) August 31, 2023 08:22
@elviskahoro elviskahoro merged commit c5e30ba into warpdotdev:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants