Skip to content

add nativescript workflows#38

Merged
alokedesai merged 5 commits intowarpdotdev:mainfrom
erodriguezh:feature/add-nativescript-workflows
Apr 20, 2022
Merged

add nativescript workflows#38
alokedesai merged 5 commits intowarpdotdev:mainfrom
erodriguezh:feature/add-nativescript-workflows

Conversation

@erodriguezh
Copy link
Copy Markdown

Hi Workflow Team,

I added the workflows for NativeScript.

Best

@elviskahoro elviskahoro requested a review from alokedesai April 10, 2022 17:53
@elviskahoro
Copy link
Copy Markdown

@erodriguezh I'm gonna add aloke as a reviewer. Thanks again for opening a PR and adding native script! You've added a lot of workflows, we appreciate it a lot!

@elviskahoro
Copy link
Copy Markdown

@erodriguezh if you're in our discord what's your username so I can add the contributor discord role?

@erodriguezh
Copy link
Copy Markdown
Author

@elviskahoro my username is erodr#3149, I'm not sure if the hash number is necessary 😅

Copy link
Copy Markdown
Member

@ianhodge ianhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @erodriguezh ! Thank you SO much for creating all these workflows. This is super beneficial to the whole Warp community.

One small note - right now the title and descriptions of these workflows are a little vague and I think should be a little more specific to nativescript. For instance the unit test workflow "Configures your project for unit testing with a selected framework" could be "Configures your NativeScript project for unit testing with a selected framework." This way, users who are not searching specifically for a NativeScript command won't be confused by the contents of the workflow, and users who want to search for a NativeScript command can find it more easily.

Let me know if you have any questions and thank you so much again for contributing! This is really amazing.

@warpdotdev-devx
Copy link
Copy Markdown
Member

warpdotdev-devx commented Apr 12, 2022 via email

@erodriguezh
Copy link
Copy Markdown
Author

Hi @ianhodge,

Thanks for your feedback, it is a good point. Please check the latest commit, I added accuracy to the titles and descriptions.

Copy link
Copy Markdown
Member

@ianhodge ianhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for addressing the feedback. There seems to be a small lint error in update_nativescript_dependencies_to_the_latest_version.yaml - mind addressing before merging?

@erodriguezh
Copy link
Copy Markdown
Author

There seemed to be an issue with double quotes, should be ok now.

@erodriguezh erodriguezh force-pushed the feature/add-nativescript-workflows branch from c417a3d to dfca0b1 Compare April 17, 2022 05:33
command: "ns platform add {{platform}}"
tags:
- ns
- tns
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @erodriguezh! Thanks so much for your contribution. One thing i'm noticing is that we have duplicated tags for ns, tns, and nativescript here. Would it be possible to consolidate and just have the nativescript tag instead?

@alokedesai alokedesai merged commit 59cabf9 into warpdotdev:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants