add nativescript workflows#38
Conversation
|
@erodriguezh I'm gonna add aloke as a reviewer. Thanks again for opening a PR and adding native script! You've added a lot of workflows, we appreciate it a lot! |
|
@erodriguezh if you're in our discord what's your username so I can add the contributor discord role? |
|
@elviskahoro my username is erodr#3149, I'm not sure if the hash number is necessary 😅 |
ianhodge
left a comment
There was a problem hiding this comment.
Hey @erodriguezh ! Thank you SO much for creating all these workflows. This is super beneficial to the whole Warp community.
One small note - right now the title and descriptions of these workflows are a little vague and I think should be a little more specific to nativescript. For instance the unit test workflow "Configures your project for unit testing with a selected framework" could be "Configures your NativeScript project for unit testing with a selected framework." This way, users who are not searching specifically for a NativeScript command won't be confused by the contents of the workflow, and users who want to search for a NativeScript command can find it more easily.
Let me know if you have any questions and thank you so much again for contributing! This is really amazing.
|
Just got you added!
|
|
Hi @ianhodge, Thanks for your feedback, it is a good point. Please check the latest commit, I added accuracy to the titles and descriptions. |
|
There seemed to be an issue with double quotes, should be ok now. |
c417a3d to
dfca0b1
Compare
| command: "ns platform add {{platform}}" | ||
| tags: | ||
| - ns | ||
| - tns |
There was a problem hiding this comment.
Hey @erodriguezh! Thanks so much for your contribution. One thing i'm noticing is that we have duplicated tags for ns, tns, and nativescript here. Would it be possible to consolidate and just have the nativescript tag instead?
Hi Workflow Team,
I added the workflows for NativeScript.
Best