feat(specs): adds cypress workflows#46
Conversation
|
Thanks @jordanpowell88! |
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
I have a small comment about clarifying what "mobile" means here. LGTM besides that though! Thank you so much for contributing!
| @@ -0,0 +1,15 @@ | |||
| name: Run Cypress Headless on Mobile | |||
There was a problem hiding this comment.
I'm by no means an expert on cypress, but my understanding is this command is just setting the height and width to a certain size, regardless of whether it's a mobile device. It may be useful to name this workflow "Run Cypress Headless on Mobile Viewport" and the other one "Open Cypress in Mobile Viewport" to make that more clear
There was a problem hiding this comment.
Thanks for the feedback @alokedesai . Let me provide a bit more feedback in regards to Cypress. Essentially there are 2 different ways to "run" Cypress.
open essentially opens the cypress app and allows users to click on which tests they want to run, etc
run essentially runs the cypress app headless and tests every spec file.
It is a bit confusing but that is why we chose that specific verbiage in regards to open vs run.
Does this help?
There was a problem hiding this comment.
Thank you for the context, the difference between "run" and "open" makes sense to me! Could we change "mobile" to "mobile viewport" though? I think that will help explain the actual command that's executed, which just hardcodes a small "mobile-sized" viewport
jordanpowell88
force-pushed
the
add-cypress-workflow
branch
from
13ee320 to
982f6ee
Compare
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
Thank you so much for contributing!
|
@jordanpowell88 Are you in our Discord btw? Can you let me know your username so I can add the contributor role? |
Yes. |
3 participants
This PR adds 4 cypress workflows