feat(specs): ✨ add turborepo workflows#51
feat(specs): ✨ add turborepo workflows#51alokedesai merged 3 commits intowarpdotdev:mainfrom Wyatt-Stanke:main
Conversation
Hello! I have added 4 Turborepo workflows. I know that is not a lot, but Turborepo is a minimal tool.
|
@Wyatt-Stanke thanks for doing this! Are you in our Discord, if so what's your username so I can add the contributor role? |
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
Overall looks great, thank you so much for contributing! Just had a small comment on naming here to avoid naming confusion with the word "workflows"
| - turborepo | ||
| arguments: | ||
| - name: workflows | ||
| description: The workflows to run. |
There was a problem hiding this comment.
nit: could we refer to the argument that's passed to npx turbo run as tasks instead of workflows (in the workflow itself and in the documentation). That's how turborepo references this argument, and I think that will avoid the name confusion with Warp workflows
There was a problem hiding this comment.
With turbo run, you run a pipeline which in turn runs tasks.
Looks like I accidentally mixed up Warp's workflows with Turborepo's pipelines.
Extra info:
Pipelines | Turborepo
CLI Reference | Turborepo
There was a problem hiding this comment.
Thanks for the pointers! I was reading https://turborepo.org/docs/features/pipelines#defining-a-pipeline which says
Each key in the pipeline object is the name of a task that can be executed by turbo run
which made me think it was really the task that turberepo runs (that is defined in a pipeline). I'm by no means an expert on this command though, so happy to leave as pipelines if you believe that is more correct!
Hello! My discord tag is |
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
LGTM, thank you for contributing! See my comment about pipelines to tasks, i'm by no means an expert here, so defer to you if you think pipelines is a better name
| - turborepo | ||
| arguments: | ||
| - name: workflows | ||
| description: The workflows to run. |
There was a problem hiding this comment.
Thanks for the pointers! I was reading https://turborepo.org/docs/features/pipelines#defining-a-pipeline which says
Each key in the pipeline object is the name of a task that can be executed by turbo run
which made me think it was really the task that turberepo runs (that is defined in a pipeline). I'm by no means an expert on this command though, so happy to leave as pipelines if you believe that is more correct!
Yeah, the documentation is a little confusing when it comes to what's what, but |
|
LGTM |
🚀 |
3 participants
Hello! I have added 4 Turborepo workflows. I know that is not a lot, but Turborepo is a minimal tool.