Skip to content

Elvis/pr template#53

Merged
elviskahoro merged 5 commits intomainfrom
elvis/pr_template
Apr 18, 2022
Merged

Elvis/pr template#53
elviskahoro merged 5 commits intomainfrom
elvis/pr_template

Conversation

@elviskahoro
Copy link
Copy Markdown

No description provided.

@elviskahoro elviskahoro requested a review from alokedesai April 18, 2022 17:53
@@ -0,0 +1,5 @@
# Pull Request Template
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the pull request template and just make both of these their own header. It should be obvious that it's a template from the fact that they're seeing it in the PR description

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

@elviskahoro elviskahoro requested a review from alokedesai April 18, 2022 19:05
@elviskahoro elviskahoro merged commit 102bff5 into main Apr 18, 2022
@elviskahoro elviskahoro deleted the elvis/pr_template branch April 18, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants