added git workflow update_git_index_after_ignoring_files.yaml#80
Merged
alokedesai merged 3 commits intowarpdotdev:mainfrom May 12, 2022
Merged
added git workflow update_git_index_after_ignoring_files.yaml#80alokedesai merged 3 commits intowarpdotdev:mainfrom
alokedesai merged 3 commits intowarpdotdev:mainfrom
Conversation
alokedesai
requested changes
May 12, 2022
Member
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
Thank you so much for contributing--this looks great! Just have one comment about the tags
Comment on lines
+11
to
+12
| - gitignore | ||
| - version control |
Member
There was a problem hiding this comment.
in our experience, the best workflows have fewer tags (see https://github.com/warpdotdev/workflows#what-makes-a-useful-workflow). Given that--could we remove the gitignore and version control flags?
alokedesai
approved these changes
May 12, 2022
Member
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
LGTM! 🚀
Thanks so much @vjindal0112! Looking forward to seeing you soon :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes (updated or new workflows)
added git workflow
update_git_index_after_ignoring_files.yamlIt covers the case of regenerating the git index after ignoring files which were previously committed to your repository.