Skip to content

Replace foo with {{pattern}}#96

Merged
alokedesai merged 1 commit intowarpdotdev:mainfrom
splitDiff:patch-1
Jun 27, 2022
Merged

Replace foo with {{pattern}}#96
alokedesai merged 1 commit intowarpdotdev:mainfrom
splitDiff:patch-1

Conversation

@splitDiff
Copy link
Copy Markdown
Contributor

Allows proper copy example function.

Description of changes

Updated find_all_files_in_a_directory_that_dont_contain_a_string

Allows proper copy example function.
Copy link
Copy Markdown
Member

@alokedesai alokedesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alokedesai alokedesai enabled auto-merge June 27, 2022 13:42
@alokedesai alokedesai merged commit 3c83735 into warpdotdev:main Jun 27, 2022
@drecali
Copy link
Copy Markdown

drecali commented Jun 28, 2022

@alokedesai
I opened PR #93 last week fixing the same issue and trying to improve the workflow but I didn't receive any feedback even though I tried to document my changes well in the description. Did I do something wrong or was my title not ideal?

@alokedesai
Copy link
Copy Markdown
Member

Hey @drecali, this is entirely my fault, I apologize. I missed the notification for your PR and then saw this and approved it. At the very minimum, I'd love to make sure you get a contributor badge on Discord, but please also continue to submit contributions here. It's much appreciated <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants