[pull] androidx-main from androidx:androidx-main#483
Merged
pull[bot] merged 9 commits intowarting:androidx-mainfrom Sep 15, 2025
Merged
[pull] androidx-main from androidx:androidx-main#483pull[bot] merged 9 commits intowarting:androidx-mainfrom
pull[bot] merged 9 commits intowarting:androidx-mainfrom
Conversation
The `setCameraOpenRetryMaxTimeoutInMillis` value from `CameraXConfig` was not being applied correctly for the CameraPipe backend. An inverted boolean check in `CameraFactoryProvider` caused the timeout to be ignored unless it was set to the default value of -1. This change corrects the conditional check to properly handle the `-1L` sentinel value. Bug: 444627589 Test: CameraStateRobolectricTest covers this behavior. Change-Id: Ice310e397c5597131a0a5aa8cc3f6de6389b8f0d
Add the new `TransitionState` sealed class. This API will represent the physical state of a navigation gesture, either `Idle` or `InProgress`. This class intentionally contains no generics and is separate from navigation history (`Info`). It is the foundational step in refactoring the dispatcher to expose two distinct global state flows (`TransitionState` and `HistoryState`) instead of the old merged generic state. RelNote: "Introduce the new `TransitionState` sealed class. This will serve as the core API for observing gesture state, separate from navigation history." Bug: 444734264 Test: existing passes Change-Id: Id4beb114ebc4ca33b8810de2d1cf9d57f7ec2336
Add a new public, read-only `transitionState` property to the `NavigationEventHandler`. The handler is now responsible for updating its own `transitionState` whenever its gesture callbacks (`doOn...Started`, `...Progressed`, `...Completed`, etc.) are invoked. The state flips to `InProgress` when a gesture starts and returns to `Idle` when it terminates. This makes the active handler the source of truth for the current gesture state. The processor will read this public property to drive the new global `dispatcher.transitionState` flow. RelNote: "Add a new public, read-only `transitionState: TransitionState` property to `NavigationEventHandler`. Handlers now maintain their own transition state, which external systems can observe." Bug: 444734264 Test: existing passes Change-Id: I9acd2b09de191f33cb200169fc1b4d3bb74dd17a
The Camera2ImplConfig in CameraPipe integration leaves options in the global namespace (of the package), which is different than Camera2 which places these constants in Camera2ImplConfig. Make them API compatible by putting these constants inside the companion object marked with @JvmField Bug: 435076868 Test: Unit tests Change-Id: If1fb225d613c3a2bd1132c7184f29a565e307006
Fix incorrect KDoc in Camera2CameraInfo. A type parameter doesn't need to be enclosed with '<>', and this is causing exceptions in the static analyzer. Bug: 435076868 Test: :docs-tip-of-tree:docs Change-Id: I51f8c1f035f5faed50fa511bafddb17200baf4b3
* changes: Fix incorrect KDoc in Camera2CameraInfo Make Camera2ImplConfig API compatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )