Fix locale.Error: unsupported locale setting in minimal environments#18
Merged
Fix locale.Error: unsupported locale setting in minimal environments#18
Conversation
Co-authored-by: wasertech <79070834+wasertech@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] locale.Error: unsupported locale setting
Fix locale.Error: unsupported locale setting in minimal environments
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs when running the translator in minimal environments (like Makefiles, containers, or systems with incomplete locale configurations) where
locale.setlocale(locale.LC_ALL, '')fails withlocale.Error: unsupported locale setting.Problem
The issue manifested as:
This prevented the translator from running in environments where locale settings are not properly configured or supported.
Solution
Wrapped the
locale.setlocale(locale.LC_ALL, '')call in a try-except block to gracefully handlelocale.Errorexceptions. The locale setting is used for convenience/formatting but is not critical to the core translation functionality, as evidenced by theget_sys_lang_format()function already having its own fallback logic.Changes
translator/main.pyTesting
Verified the fix handles various problematic environments:
Fixes #17.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.