Adding cosmonic to sponsor slider#6
Merged
Merged
Conversation
brooksmtownsend
approved these changes
May 17, 2021
ericgregory
added a commit
that referenced
this pull request
Jun 3, 2026
… + FAQ guard
Four fixes surfaced by the structured-data PR code review.
1. M6 glossary entity cross-link was silently broken — 11 of 14
entity_slug values in src/data/glossary.json used wrong casing vs the
keys in src/data/entities.json, so getEntityBySlug() returned undefined
and no sameAs edge ever landed. The 12th entry referenced 'WashCli',
which doesn't exist as an entity (the 'wash' key does). Corrected:
CapabilityBasedSecurity -> capabilityBasedSecurity, AmbientAuthority
-> ambientAuthority, DenyByDefault -> denyByDefault, BlastRadius ->
blastRadius, Mcp -> MCP, Nats -> NATS, AiSandbox -> AISandbox,
VibeCoding -> vibeCoding, AgenticAi -> agenticAI, WashCli -> wash,
Wasi -> WASI. All 14 cross-links now resolve.
2. doc-page-schema.tsx claimed in its JSDoc to support a frontmatter
'author:' override but the code hardcoded author to PUBLISHER_REF.
Implemented buildDocAuthor() that accepts a string, an object with
name/title/url/image, or an array of either — falling back to the
wasmCloud project Organization when nothing parseable is present.
Mirrors the blog buildAuthors() pattern at a lower verbosity since
docs don't use authors.yml.
3. breadcrumbs.tsx produced visually wrong intermediate crumbs:
/docs/v1/concepts/ -> Home / Docs / V1 / Concepts
/blog/page/2/ -> Home / Blog / Page / 2
Versioned-docs version segments and blog/community pagination
markers are URL path components, not real navigable pages. They now
contribute to URL accumulation for subsequent crumbs but are absent
from the visible chain — except when a version segment is the LAST
segment (e.g. landing on '/docs/v1/' itself). Version labels also
preserve their original lowercase casing so 'v1' renders as 'v1' not
'V1' on the landing-page case. Position numbering recomputed after
skips so the BreadcrumbList list-item positions stay 1..N contiguous.
4. faq-schema.tsx had no mounting guard — would emit FAQPage JSON-LD on
any page that imported it. Risk #6 in the spike is exactly this
(FAQPage schema on a non-Q&A page is a manual-action risk). Added a
useDoc-based path check that allows /docs/faq/ (and, defensively,
/docs/{version}/faq/) and silently returns null elsewhere.
Signed-off-by: Eric Gregory <eric@cosmonic.com>
LiamRandall
pushed a commit
that referenced
this pull request
Jun 3, 2026
… + FAQ guard
Four fixes surfaced by the structured-data PR code review.
1. M6 glossary entity cross-link was silently broken — 11 of 14
entity_slug values in src/data/glossary.json used wrong casing vs the
keys in src/data/entities.json, so getEntityBySlug() returned undefined
and no sameAs edge ever landed. The 12th entry referenced 'WashCli',
which doesn't exist as an entity (the 'wash' key does). Corrected:
CapabilityBasedSecurity -> capabilityBasedSecurity, AmbientAuthority
-> ambientAuthority, DenyByDefault -> denyByDefault, BlastRadius ->
blastRadius, Mcp -> MCP, Nats -> NATS, AiSandbox -> AISandbox,
VibeCoding -> vibeCoding, AgenticAi -> agenticAI, WashCli -> wash,
Wasi -> WASI. All 14 cross-links now resolve.
2. doc-page-schema.tsx claimed in its JSDoc to support a frontmatter
'author:' override but the code hardcoded author to PUBLISHER_REF.
Implemented buildDocAuthor() that accepts a string, an object with
name/title/url/image, or an array of either — falling back to the
wasmCloud project Organization when nothing parseable is present.
Mirrors the blog buildAuthors() pattern at a lower verbosity since
docs don't use authors.yml.
3. breadcrumbs.tsx produced visually wrong intermediate crumbs:
/docs/v1/concepts/ -> Home / Docs / V1 / Concepts
/blog/page/2/ -> Home / Blog / Page / 2
Versioned-docs version segments and blog/community pagination
markers are URL path components, not real navigable pages. They now
contribute to URL accumulation for subsequent crumbs but are absent
from the visible chain — except when a version segment is the LAST
segment (e.g. landing on '/docs/v1/' itself). Version labels also
preserve their original lowercase casing so 'v1' renders as 'v1' not
'V1' on the landing-page case. Position numbering recomputed after
skips so the BreadcrumbList list-item positions stay 1..N contiguous.
4. faq-schema.tsx had no mounting guard — would emit FAQPage JSON-LD on
any page that imported it. Risk #6 in the spike is exactly this
(FAQPage schema on a non-Q&A page is a manual-action risk). Added a
useDoc-based path check that allows /docs/faq/ (and, defensively,
/docs/{version}/faq/) and silently returns null elsewhere.
Signed-off-by: Eric Gregory <eric@cosmonic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.