Open
Conversation
The previous setup relied on pnpm run dev working, which in turn was dependent on the node inspector module. But this is not supported yet, we're not trying to reproduce the entire node ecosystem (to begin with) instead only the hosting capabilities. So the workaround here is to build the Nextjs ssr prod dist with node, and then attempt to serve this production dist with edgejs. If this works, then the test has passed: Edgejs is compatbile.
baalimago
force-pushed
the
fix/example-framework-compatibility
branch
from
0a014ca to
fe0c421
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
To validate run:
make framework-test-resetmake framework-test