Simplify object initialization path with relocations #5498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No documentation updates required. |
wakabat
changed the title
Member
|
Thanks for the PR! We need to test the branch locally, and try a few cases... but in general looks good! |
wakabat
force-pushed
the
use-relocation-to-setup-function-address-in-objects
branch
from
97b4ba8 to
64c0326
Compare
Contributor
Author
|
Rebased against tip. |
Previous code relies on C glue code to piece metadata and actual function addresses after linking together. This change refines the process, so proper relocations are generated for each function / trampoline when building the object. This way a linker should be able to fulfill the task of filling in actual function addresses in the final binary, there is no need to use glue code to do the memcpy work anymore.
wakabat
force-pushed
the
use-relocation-to-setup-function-address-in-objects
branch
from
64c0326 to
cd7731e
Compare
xdoardo
approved these changes
Apr 23, 2025
Member
|
We tested locally (in aarch64 and x86_64) and it works well. We should be good to merge once the majority of tests pass (some jobs seem to be failing, but are unrelated to this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code relies on C glue code to piece metadata and actual function addresses after linking together. This change refines the process, so proper relocations are generated for each function / trampoline when building the object. This way a linker should be able to fulfill the task of filling in actual function addresses in the final binary, there is no need to use glue code to do the memcpy work anymore.