Decide on env variables prefix for the web app

[infomiho]

We used Create React App before which has the rule of only allowing REACT_APP_ prefixed env variables.

This forces our users to define all variables with that prefix. When we start using Vite, we'll be able to change the prefix to anything we want, and we should consider which prefix that should be.

1. REACT_APP_ keep backwards compatibility
2. VITE_ is default in Vite world
3. WASP_ is our own and doesn't expose unimportant implementation details

• if we changed from Vite to something else we wouldn't need to think about it

[Martinsos]

Wasp Wasp Wasp Wasp :D.

Let's go with WASP_!

[Zeko369]

I'd go with WASP_PUBLIC_ (exposed in server/client land) and if you really want WASP_ (just as a convention in the server land) since just having one for both (without explicitly saying it's PUBLIC) could lead to devs accidentally exposing tokens they didn't want in the client build

(technically any prefix is ok, since Vite does "tree shaking" of envs so only the ones used will be exposed, but if you name them PUBLIC it makes the intent clearer for devs)

[Martinsos]

I'd go with WASP_PUBLIC_ (exposed in server/client land) and if you really want WASP_ (just as a convention in the server land) since just having one for both (without explicitly saying it's PUBLIC) could lead to devs accidentally exposing tokens they didn't want in the client build

(technically any prefix is ok, since Vite does "tree shaking" of envs so only the ones used will be exposed, but if you name them PUBLIC it makes the intent clearer for devs)

Not a bad idea! It can indeed be confusing what is public and what is not.