Refactor Docker config for testing #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
=========================================
Coverage 69.77% 69.77%
Complexity 3193 3193
=========================================
Files 655 655
Lines 15592 15592
Branches 903 903
=========================================
Hits 10879 10879
Misses 4325 4325
Partials 388 388Continue to review full report at Codecov.
|
Contributor
|
@all-contributors please add @lpatino10 @padamstx for code, design, bug |
Contributor
|
I've put up a pull request to add @lpatino10! 🎉 |
Contributor
|
@all-contributors please add @lpatino10, @mkistler, @padamstx for code, design, bug |
Closed
Contributor
|
🎉 This PR is included in version 7.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is essentially a modified version of this earlier PR by our friend @kingsodigie. Sorry I had to steal the change but thanks for the initial work! 😬
I went through that PR and was having a little trouble getting things set up to work during the
docker buildstep. I added a little more structure and some extra documentation to hopefully make this process easier to get up and running.For verification, you should be able to
cdinto thedockerdirectory as-is and rundocker build -t <tag>to run a simple hello world program.