Sdk passage patch #1130
Merged
Sdk passage patch #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate gen tag '2.3.1'
mamoonraja
previously approved these changes
Sep 24, 2020
kevinkowa
dismissed stale reviews from germanattanasio and mamoonraja
via
bb87b55
mediumTaj
previously approved these changes
Sep 28, 2020
Contributor
mediumTaj
left a comment
mediumTaj
left a comment
There was a problem hiding this comment.
👍 looks good! One question but not a big deal....
| super.setUp(); | ||
| String apiKey = getProperty("discovery.apikey"); | ||
| String url = getProperty("discovery.url"); | ||
| String url = "https://api.us-south.discovery.watson.cloud.ibm.com"; |
Contributor
There was a problem hiding this comment.
Should this be hardcoded? Eventually we should update the credentials to use the proper urls.
Contributor
|
🎉 This PR is included in version 8.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes for the v8.4.1 release of the Java SDK with a patch to fix PassagesPerDocument for discovery-v2
The tags used for this release are:
git checkout sdk-2020-08-20
Generator: 2.3.1