Sdk major release 2020 #1143
Merged
Sdk major release 2020 #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update gateway urls
[docs] Revise PI deprecation, add VisRec deprecation
BREAKING CHANGE: api def tag 'sdk-major-release-2020' gen tag 3.19.0
…create & update Collection
mediumTaj
suggested changes
Dec 2, 2020
Contributor
mediumTaj
left a comment
mediumTaj
left a comment
There was a problem hiding this comment.
Looks good overall, can you check to see if the handwritten change has been applied to timestamps and word confidence? They should be an array of arrays.
speech-to-text/src/test/java/com/ibm/watson/speech_to_text/v1/SpeechToTextTest.java
Outdated
Show resolved
Hide resolved
speech-to-text/src/test/java/com/ibm/watson/speech_to_text/v1/SpeechToTextTest.java
Outdated
Show resolved
Hide resolved
speech-to-text/src/test/java/com/ibm/watson/speech_to_text/v1/SpeechToTextTest.java
Outdated
Show resolved
Hide resolved
speech-to-text/src/test/java/com/ibm/watson/speech_to_text/v1/SpeechToTextTest.java
Outdated
Show resolved
Hide resolved
…re done cleanup was called after each test
mediumTaj
approved these changes
Dec 2, 2020
Contributor
mediumTaj
left a comment
mediumTaj
left a comment
There was a problem hiding this comment.
👍 looks good! Once this is merged please create a PR to master for final review
Contributor
|
🎉 This PR is included in version 9.0.0-rc.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: api def tag 'sdk-major-release-2020' gen tag 3.19.0