Skip to content

Conversation

@germanattanasio
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Apr 24, 2017

Codecov Report

Merging #671 into develop will decrease coverage by 14.51%.
The diff coverage is 62.5%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop     #671       +/-   ##
==============================================
- Coverage      57.98%   43.46%   -14.52%     
+ Complexity      1711     1205      -506     
==============================================
  Files            390      391        +1     
  Lines           7837     7877       +40     
  Branches         474      479        +5     
==============================================
- Hits            4544     3424     -1120     
- Misses          2937     4165     +1228     
+ Partials         356      288       -68
Impacted Files Coverage Δ Complexity Δ
...oper_cloud/conversation/v1/model/CreateIntent.java 0% <ø> (-51.86%) 0 <0> (-1)
...loper_cloud/conversation/v1/model/CreateValue.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...r_cloud/conversation/v1/model/UpdateWorkspace.java 0% <ø> (-23.81%) 0 <0> (-1)
...r_cloud/conversation/v1/model/CreateWorkspace.java 0% <ø> (-41.27%) 0 <0> (-1)
...oper_cloud/conversation/v1/model/CreateEntity.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...conversation/v1/model/WorkspaceExportResponse.java 0% <0%> (-29.42%) 0 <0> (-10)
...loud/conversation/v1/model/PaginationResponse.java 75% <100%> (+59.61%) 9 <2> (+7) ⬆️
...n/v1/model/util/PaginationResponseTypeAdapter.java 70.96% <70.96%> (ø) 5 <5> (?)
...veloper_cloud/text_to_speech/v1/model/Phoneme.java 0% <0%> (-100%) 0% <0%> (-3%)
...oper_cloud/alchemy/v1/model/LanguageSelection.java 0% <0%> (-100%) 0% <0%> (-1%)
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc8a5a8...1b291a5. Read the comment docs.

🐛 Remove unused variables

🆕 Adding another date parser for Conversation

:fix: Add Enums to WorkspaceExportResponse #670

Print timezone when printing Json

:fix: Fix Javadoc

Remove useless testCompile projects from dialog

:memo: Update javadoc

:fire: revert data deserializer changes
Copy link

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Comment should be updated.



/**
* Classifier Status.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "Workspace Status".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants