4831/recognize stream comments #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanattanasio
approved these changes
Jul 17, 2018
|
Agreed. I'll change the javascript sdk for now, but I will be looking into bringing it in as a dependency moving forward. Or at the very least, changing the javascript sdk to rely more on this sdk so that there is less repeated code. |
anweshan
approved these changes
Jul 17, 2018
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 35 35
Lines 4390 4390
Branches 553 553
=======================================
Hits 3687 3687
Misses 324 324
Partials 379 379
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeffpk62 noticed that the documentation for a few parameters in
RecognizeStreamwas incorrect and did not match the behavior of the service - specifically, they were listing alternate default values for use of the service in object mode when the defaults are not actually different.This PR addresses this inconsistency in the JSDoc comments.