Regenerate sdk release 7 #778
Conversation
| * @param {string} [params.new_parent] - The ID of the parent dialog node. | ||
| * @param {string} [params.new_previous_sibling] - The ID of the previous sibling dialog node. | ||
| * @param {Object} [params.new_output] - The output of the dialog node. For more information about how to | ||
| * @param {DialogNodeOutput} [params.new_output] - The output of the dialog node. For more information about how to |
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 83.14% 83.13% -0.02%
==========================================
Files 35 35
Lines 4498 4513 +15
Branches 568 572 +4
==========================================
+ Hits 3740 3752 +12
Misses 363 363
- Partials 395 398 +3
Continue to review full report at Codecov.
|
|
I think you forgot to apply the manual changes for the create classifier in VR. The models are wrong |
|
@germanattanasio I applied the manual changes, which are just to parse out examples with custom names. What is new is the filename parameters, which the generator now adds to every file type parameter in the SDK. I can see how this may be problematic, so either I can remove the filename code or edit it so that the code parses custom filenames the same way it's parsing for the examples. Both would require additional manual changes. Let me know what you think cc @mkistler |
| * depict the visual subject of any of the classes of the new classifier. Must contain a minimum of 10 images. | ||
| * | ||
| * Encode special characters in the file name in UTF-8. | ||
| * @param {string} [params.classname_positive_examples_filename] - The filename for classname_positive_examples. |
There was a problem hiding this comment.
see this description
| * depict the visual subject of any of the classes of the new classifier. Must contain a minimum of 10 images. | ||
| * | ||
| * Encode special characters in the file name in UTF-8. | ||
| * @param {string} [params.classname_positive_examples_filename] - The filename for classname_positive_examples. |
There was a problem hiding this comment.
see this descriptions
|
Were the warnings in Visual Recognition generated? |
|
The warnings are generated when The only change in VR is adding the filename params. There are no differences in manual changes. German is suggesting updates to the documentation for the filename params. What do you think won't work? |
|
@germanattanasio I realized that the filename parameter wouldn't match the positive example parameter name since those are custom. I made some edits to resolve this and would like your opinion. I think this works well but it will make it harder to generate this code in the future. Let me know what you think |
|
🎉 This PR is included in version 3.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Regenerate with latest changes to API definitions and Watson Swagger Codegen.