fix: added commitlint rules #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
=======================================
Coverage 89.92% 89.92%
=======================================
Files 21 21
Lines 3494 3494
Branches 298 298
=======================================
Hits 3142 3142
Misses 346 346
Partials 6 6Continue to review full report at Codecov.
|
dpopp07
reviewed
Apr 24, 2019
| "always", | ||
| "lower-case" | ||
| ], | ||
| "subject-case": [ |
There was a problem hiding this comment.
What's your reasoning here? I feel like we want it to be always lower case
There was a problem hiding this comment.
Realizing that this probably looks word by word, it makes sense to allow other cases to include variable names in commit messages
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commitlintrules. Resolves Include commitlint.config.js in repo #867npm auditreview.Checklist
npm testpasses (tip:npm run autofixcan correct most style issues)