Skip to content

Conversation

@esminerva
Copy link
Contributor

Checklist

  • documentation is changed or added

@esminerva esminerva force-pushed the debug branch 2 times, most recently from 6e23054 to 73e2e87 Compare May 21, 2019 16:20
@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #888 into master will increase coverage by 4.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   54.65%   59.34%   +4.69%     
==========================================
  Files          18       18              
  Lines        3396     4339     +943     
  Branches      292      730     +438     
==========================================
+ Hits         1856     2575     +719     
- Misses       1534     1760     +226     
+ Partials        6        4       -2
Impacted Files Coverage Δ
text-to-speech/v1.ts 45% <0%> (-0.72%) ⬇️
speech-to-text/v1-generated.ts 44.39% <0%> (-0.4%) ⬇️
lib/common.ts 100% <0%> (ø) ⬆️
lib/synthesize-stream.ts 85% <0%> (+1.66%) ⬆️
speech-to-text/v1.ts 34.09% <0%> (+2.58%) ⬆️
personality-insights/v3.ts 92.39% <0%> (+3.23%) ⬆️
visual-recognition/v3.ts 44.11% <0%> (+3.37%) ⬆️
tone-analyzer/v3.ts 91.76% <0%> (+3.6%) ⬆️
compare-comply/v1.ts 70.81% <0%> (+3.85%) ⬆️
discovery/v1.ts 39.64% <0%> (+4.29%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9689d...4e86717. Read the comment docs.

@dpopp07
Copy link
Contributor

dpopp07 commented May 21, 2019

This resolves #883

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@dpopp07 dpopp07 merged commit 4f9db37 into master May 22, 2019
@dpopp07 dpopp07 deleted the debug branch May 22, 2019 14:54
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants