Support expanding elements in MCNP by weight percent#102
Merged
nstauff merged 5 commits intowatts-dev:developmentfrom Jun 28, 2023
Merged
Support expanding elements in MCNP by weight percent#102nstauff merged 5 commits intowatts-dev:developmentfrom
nstauff merged 5 commits intowatts-dev:developmentfrom
Conversation
nstauff
approved these changes
Jun 27, 2023
Contributor
nstauff
left a comment
There was a problem hiding this comment.
Thanks for this development. do you want to mention this in the documentation? https://watts.readthedocs.io/en/latest/user/plugins.html
Contributor
Author
|
@nstauff Just updated the example in the documentation to use weight fractions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current, the
PluginMCNPclass allows a user to expand elements that appear in a material definition according to their naturally occurring isotopes. However, this only works when the corresponding fraction is given as an atom percent. This PR extends this capability to work for weight fractions (specified as negative numbers in a MCNP material card).Note that this required access to atomic masses, which I've pulled in from the AME2020 data file.
Fixes #101
Checklist: