Allow individual directory names in database to be specified#107
Merged
nstauff merged 2 commits intowatts-dev:developmentfrom Jul 19, 2023
Merged
Allow individual directory names in database to be specified#107nstauff merged 2 commits intowatts-dev:developmentfrom
nstauff merged 2 commits intowatts-dev:developmentfrom
Conversation
nstauff
approved these changes
Jul 19, 2023
Contributor
nstauff
left a comment
There was a problem hiding this comment.
Thanks @paulromano - I reviewed and tested and it works fine. One thought - would it make sense to add an option to return the file to main directory? I think this would be useful to some users.
Contributor
Author
|
Returning files to the main directory would break the result/database functionality since there is an assumption that a single result is stored in its own directory. If we were to do that, the only way I could imagine it working is to simply not save such a result to the database, which may also be confusing to a user if they're expecting to be able to retrieve that result later. In any case, if we were to consider such a change, it would likely be substantial and require a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normally directory names in the database are selected at random with the
uuidmodule. However, in some cases users may wish to specify the directory names. This PR adds a newoutput_dirargument onPlugin.__call__that enables the relative directory path to be specified.Checklist: