Merged
Conversation
Comments removed as indicated.
Contributor
Author
|
@paulromano @nstauff Ready for review |
nstauff
requested changes
Aug 16, 2024
Contributor
nstauff
left a comment
nstauff
left a comment
There was a problem hiding this comment.
Thanks @JiaZhou-PU - this looks quite good but I have a few comments to request improvements in documentation
Contributor
Author
|
@nstauff Thanks! Comments are addressed, and ready to merge. @paulromano Thank you for the fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add GCMat plugin and include one example of GCMat in example folder
Checklist: