Allow executable to be specified when creating plugins#75
Allow executable to be specified when creating plugins#75nstauff merged 3 commits intowatts-dev:developmentfrom
Conversation
|
Thanks @paulromano - this looks good to me. @zhieejhia93 - could you try this out for SAS and RELAP executables? |
|
@paulromano - while trying from my laptop, I am getting the following error - any idea how to fix this? |
|
@nstauff Oops, sorry I got too fancy. The |
|
Thanks @paulromano - this is now running on my end. |
|
Thanks for the changes @paulromano and sorry for the delayed response. The changes work fine for the SAS executables. However, it seems like there's a small issue with the RELAP5 plugin where I run into the following error when I provide
|
|
@zhieejhia93 the relap5 = watts.PluginRELAP(...)
params = watts.Parameters(...)
result = relap5(params, extra_args=[...])Can you give that a try? |
|
Thanks @paulromano . It worked! |
This PR adds an
executableargument to the constructor of all our plugins so that a user can specify an executable at the time the plugin is created. @nstauff ran into an issue wherePluginSerpentwas complaining that thesss2executable wasn't found, and the only way to fix it was to make sure thatsss2was found via thePATHenvironment variable. With this change, one can either 1) explicitly give the absolute path of the executable or 2) give the name of the executable and specify an associated environment variable (e.g.,SERPENT_DIR). I'll note that the way the executable is handled is now must more consistent across the different plugin classes.