Store Jinja environment in TemplateRenderer#88
Merged
nstauff merged 6 commits intowatts-dev:developmentfrom Feb 10, 2023
Merged
Store Jinja environment in TemplateRenderer#88nstauff merged 6 commits intowatts-dev:developmentfrom
nstauff merged 6 commits intowatts-dev:developmentfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a subtle change to our
TemplateRendererclass, which now stores ajinja2.Environmentinstance. This may be needed down the line for some envisioned features (e.g., special Jinja filters to be used for MCNP) and otherwise doesn't affect functionality.Two other small changes:
input_fileproperty to thePluginMCNPclassChecklist:
I have added tests that prove my fix is effective or that my feature works (if applicable)