Skip to content

Fix setting of executable for PluginABCE#94

Merged
nstauff merged 3 commits intowatts-dev:developmentfrom
paulromano:abce-exec-fix
May 3, 2023
Merged

Fix setting of executable for PluginABCE#94
nstauff merged 3 commits intowatts-dev:developmentfrom
paulromano:abce-exec-fix

Conversation

@paulromano
Copy link
Copy Markdown
Contributor

@paulromano paulromano commented Apr 24, 2023

Description

The PluginABCE class was relying on the normal executable property from PluginGeneric, which assumes the file is actually a true executable. For ABCE, it is a Python script and so we need to modify the check for the executable as is done for PyARC.

@JiaZhou-PU can you check if this resolves your issue?

Checklist:

  • My code follows the style guidelines
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG.md file (if applicable)

@JiaZhou-PU
Copy link
Copy Markdown
Contributor

JiaZhou-PU commented Apr 24, 2023

@paulromano The plugin works!
I do have some other errors

Traceback (most recent call last):
  File "/Users/l00317783/Library/CloudStorage/Box-Box/abce/run.py", line 231, in <module>
    run_model()
  File "/Users/l00317783/Library/CloudStorage/Box-Box/abce/run.py", line 163, in run_model
    initialize_logging(args, settings["constants"]["vis_lvl"])
KeyError: 'constants'

I think this is caused by recent change of ABCE, not WATTS.

@paulromano
Copy link
Copy Markdown
Contributor Author

Yes, that does indeed look like a problem with ABCE, not WATTS.

@paulromano paulromano requested a review from nstauff May 3, 2023 02:36
@nstauff
Copy link
Copy Markdown
Contributor

nstauff commented May 3, 2023

@JiaZhou-PU - could you please try it?

@JiaZhou-PU
Copy link
Copy Markdown
Contributor

@JiaZhou-PU - could you please try it?

I tried it, the plug-in works fine now.

Copy link
Copy Markdown
Contributor

@nstauff nstauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @paulromano

@nstauff nstauff merged commit 9ba368f into watts-dev:development May 3, 2023
@paulromano paulromano deleted the abce-exec-fix branch May 3, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants