Fix setting of executable for PluginABCE#94
Merged
nstauff merged 3 commits intowatts-dev:developmentfrom May 3, 2023
Merged
Conversation
Contributor
|
@paulromano The plugin works! I think this is caused by recent change of ABCE, not WATTS. |
Contributor
Author
|
Yes, that does indeed look like a problem with ABCE, not WATTS. |
Contributor
|
@JiaZhou-PU - could you please try it? |
Contributor
I tried it, the plug-in works fine now. |
nstauff
approved these changes
May 3, 2023
Contributor
nstauff
left a comment
There was a problem hiding this comment.
Thanks for the fix @paulromano
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
PluginABCEclass was relying on the normalexecutableproperty fromPluginGeneric, which assumes the file is actually a true executable. For ABCE, it is a Python script and so we need to modify the check for the executable as is done for PyARC.@JiaZhou-PU can you check if this resolves your issue?
Checklist: