Skip to content

MONIT-40739: Improve proxy error handling mechanism.#863

Merged
joannatk merged 9 commits into
devfrom
nchaparyan/MONIT-40739
Aug 2, 2023
Merged

MONIT-40739: Improve proxy error handling mechanism.#863
joannatk merged 9 commits into
devfrom
nchaparyan/MONIT-40739

Conversation

@Norayr25
Copy link
Copy Markdown
Contributor

No description provided.

laullon and others added 4 commits June 26, 2023 11:57
#858)

* MONIT-40095: The README.md example of how to utilize Dokcer with OAuth apps needs to be improved.

* Update README.md

* Minor change.

---------

Co-authored-by: German Laullon <glaullon@vmware.com>
@Norayr25 Norayr25 requested a review from laullon July 29, 2023 13:47
Copy link
Copy Markdown
Contributor

@deosu deosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Norayr25 Norayr25 requested a review from joannatk August 1, 2023 06:50
+ this.proxyAuthMethod
+ ") Status: "
+ response.getStatusInfo().getStatusCode());
String jsoneString = response.readEntity(String.class);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this typo for jsonString?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joannak-vmware fixed, thanks

@joannatk
Copy link
Copy Markdown
Contributor

joannatk commented Aug 1, 2023

LGTM, please change base branch to dev

@Norayr25 Norayr25 changed the base branch from master to dev August 1, 2023 19:05
Copy link
Copy Markdown
Contributor

@joannatk joannatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joannatk joannatk merged commit a0c04b6 into dev Aug 2, 2023
deosu added a commit that referenced this pull request Aug 9, 2023
* MONIT-40499 upgrade java-lib dependency (#862)

* Update maven.yml

* MONIT-40739: Improve proxy error handling (#863)

---------

Co-authored-by: German Laullon <glaullon@vmware.com>
Co-authored-by: Norayr25 <nchaparyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants