This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Report diagnostic counters as Delta Counters#171
Merged
sushantdewan123 merged 9 commits intowavefrontHQ:masterfrom Oct 2, 2020
Merged
Report diagnostic counters as Delta Counters#171sushantdewan123 merged 9 commits intowavefrontHQ:masterfrom
sushantdewan123 merged 9 commits intowavefrontHQ:masterfrom
Conversation
…k-vmware/wavefront-sdk-java into WavefrontSdkDeltaCounters
Contributor
Author
|
Am working on failed build. |
hanwavefront
suggested changes
Oct 1, 2020
Contributor
hanwavefront
left a comment
hanwavefront
left a comment
There was a problem hiding this comment.
a couple minor things, LGTM otherwise
src/main/java/com/wavefront/sdk/common/metrics/WavefrontSdkCounter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/wavefront/sdk/common/metrics/WavefrontSdkMetricsRegistry.java
Outdated
Show resolved
Hide resolved
src/test/java/com/wavefront/sdk/common/metrics/WavefrontSdkMetricsRegistryTest.java
Show resolved
Hide resolved
srujann
suggested changes
Oct 1, 2020
src/main/java/com/wavefront/sdk/common/metrics/WavefrontSdkDeltaCounter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/wavefront/sdk/common/metrics/WavefrontSdkDeltaCounter.java
Show resolved
Hide resolved
src/main/java/com/wavefront/sdk/common/metrics/WavefrontSdkDeltaCounter.java
Outdated
Show resolved
Hide resolved
hanwavefront
approved these changes
Oct 2, 2020
srujann
reviewed
Oct 2, 2020
src/main/java/com/wavefront/sdk/common/metrics/WavefrontSdkMetricsRegistry.java
Outdated
Show resolved
Hide resolved
srujann
approved these changes
Oct 2, 2020
sushantdewan123
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report ~sdk diagnostic counters as Delta Counters
Created WavefrontSdkDeltaCounter class
Replaced all existing internal WavefrontSdkCounters with WavefrontSdkDeltaCounters
Updated correlating Counter functions