This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Add validateEndpoint method to WavefrontClient.Builder (#169)#172
Merged
sushantdewan123 merged 3 commits intomasterfrom Oct 14, 2020
Merged
Add validateEndpoint method to WavefrontClient.Builder (#169)#172sushantdewan123 merged 3 commits intomasterfrom
sushantdewan123 merged 3 commits intomasterfrom
Conversation
Contributor
attack
commented
Oct 1, 2020
attack
commented
- Add validateEndpoint method to WavefrontClient.Builder
- add javadoc
src/main/java/com/wavefront/sdk/common/clients/WavefrontClient.java
Outdated
Show resolved
Hide resolved
basilisk487
suggested changes
Oct 2, 2020
Contributor
basilisk487
left a comment
basilisk487
left a comment
There was a problem hiding this comment.
a couple of minor comments.
also, for future PRs, please fork the repo and keep the public branches clean
src/main/java/com/wavefront/sdk/common/clients/WavefrontClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/wavefront/sdk/common/clients/WavefrontClient.java
Outdated
Show resolved
Hide resolved
attack
force-pushed
the
mg-169-validate-endpoint
branch
2 times, most recently
from
1ac2274 to
7a99020
Compare
basilisk487
approved these changes
Oct 10, 2020
sushantdewan123
approved these changes
Oct 14, 2020
* Add validateEndpoint method to WavefrontClient.Builder * add javadoc
attack
force-pushed
the
mg-169-validate-endpoint
branch
from
7a99020 to
9d1d3ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.