This repository was archived by the owner on Jan 16, 2026. It is now read-only.
WavefrontClient can send spans to different port than metrics#201
Merged
WavefrontClient can send spans to different port than metrics#201
Conversation
- sendMetric, sendSpan, sendDistribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: we recommend that Distributed Tracing customers have span-level RED metrics computed by sending spans to the Wavefront Proxy's
customTracingListenerPorts(30001 by default).WavefrontProxyClientin this SDK allowed configuring a separate port for spans, but was deprecated in #127.Until Wavefront Proxy's default listener on port 2878 can also generate span-level RED metrics, we should allow
WavefrontClientto specify a custom port when sending spans.Also, backfilled tests for WavefrontClient.