Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

[MONIT-29250] Include stack traces in run() methods#236

Merged
oppegard merged 1 commit intomasterfrom
MONIT-29250
Jun 9, 2022
Merged

[MONIT-29250] Include stack traces in run() methods#236
oppegard merged 1 commit intomasterfrom
MONIT-29250

Conversation

@oppegard
Copy link
Copy Markdown
Contributor

@oppegard oppegard commented Jun 8, 2022

Add support in MessageDepupingLogger to include a Throwable forincluding a stack trace in log output.

Used new logger method in:

  • WavefrontClient
  • WavefrontDirectIngestionClient
  • Already included stack trace: WavefrontProxyClient

Testing Notes
Manually tested with test harness app:

Sent tracing span: 'getAllUsers' to proxy
Jun 08, 2022 3:48:49 PM com.wavefront.sdk.common.clients.WavefrontClient run
WARNING: Unable to report to Wavefront cluster: 
java.io.IOException: attempt to flush closed sender
	at com.wavefront.sdk.common.clients.WavefrontClient.flush(WavefrontClient.java:632)
	at com.wavefront.sdk.common.clients.WavefrontClient.run(WavefrontClient.java:619)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

Add support in MessageDepupingLogger to include a Throwable for
including a stack trace in log output.

Used new logger method in:

- WavefrontClient
- WavefrontDirectIngestionClient
- Already included stack trace: WavefrontProxyClient
@oppegard oppegard requested review from deosu and thepeterstone June 8, 2022 22:10
Copy link
Copy Markdown

@thepeterstone thepeterstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppegard oppegard merged commit 07b126e into master Jun 9, 2022
@oppegard oppegard deleted the MONIT-29250 branch June 9, 2022 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants