This repository was archived by the owner on Aug 15, 2023. It is now read-only.
Setup @babel/plugin-transform-runtime properly with @babel/runtime#2
Open
rctay wants to merge 3 commits intowavefrontHQ:masterfrom
Open
Setup @babel/plugin-transform-runtime properly with @babel/runtime#2rctay wants to merge 3 commits intowavefrontHQ:masterfrom
rctay wants to merge 3 commits intowavefrontHQ:masterfrom
Conversation
It was listed in 'dependencies', but package-lock.json shows it to have been installed as a dev dependency. Signed-off-by: Ray Chuan Tay <rctay89@gmail.com>
This is stated in the docs: https://babeljs.io/docs/en/babel-runtime Signed-off-by: Ray Chuan Tay <rctay89@gmail.com>>
@babel/runtime is actually meant to be used with this plugin, per https://babeljs.io/docs/en/babel-plugin-transform-runtime By turning this on, we need to configure `runtimeHelpers` for rollup. This allows us to `require()` the library as-is, ie. without passing `-r regenerator-runtime` to node. Signed-off-by: Ray Chuan Tay <rctay89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@babel/runtime is actually meant to be used with this plugin, per https://babeljs.io/docs/en/babel-plugin-transform-runtime
This gives us the nice ability of
require()-ing the library as-is, ie. without passing-r regenerator-runtimeas an argument to node.