Merged
Conversation
write_wav and from_wav previously exposed hound::Error in the public API, coupling downstream crates to an implementation detail. CoreError wraps Io and Audio variants with manual Display/Error impls (no thiserror) to keep zero required dependencies. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merged
wavekat-eason
pushed a commit
that referenced
this pull request
Apr 17, 2026
## 🤖 New release * `wavekat-core`: 0.0.6 -> 0.0.7 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.0.7](v0.0.6...v0.0.7) - 2026-04-17 ### Added - add CoreError type ([#16](#16)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CoreErrorwithIoandAudiovariants to replace leakedhound::Errorin the public APIDisplay/Error/Fromimpls — nothiserrordependency, keeps zero required depsFrom<hound::Error>gated behind#[cfg(feature = "wav")]Test plan
cargo test --all-features— all 12 unit tests + 5 doc-tests passcargo clippy --workspace --all-features -- -D warnings— cleancargo fmt --all --check— clean🤖 Generated with Claude Code