fix(cli,core): trust OS CA roots for self-signed servers (#287)#288
Merged
Conversation
Member
Author
|
/gradient run checks.x86_64-linux.gradient-cache |
Member
Author
|
/gradient run checks.x86_64-linux.gradient-cache |
Member
Author
|
/gradient run checks.x86_64-linux.gradient-cache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287.
Summary
gradient loginfailed withtransport error: error sending requestagainst self-hosted instances with a self-signed CA, even when the CA was installed in the system trust store andcurlworked. The CLI's rustls config only trustedwebpki-roots, so the TLS handshake aborted before any HTTP traffic left the process — which is why nothing showed up in the reverse-proxy logs either.rustls-native-certsalongsidewebpki-rootsin both the CLI (cli/connector/src/lib.rs) and the server-side HTTP client (backend/core/src/http.rs). Native cert loading degrades silently so Nix-sandbox / minimal-container builds without/etc/ssl/certskeep working.rustls_root_store) so the change is testable and added a regression test asserting the baseline is present.Test plan
cargo checkon the CLI workspace andbackend/corecargo clippy --all-targets -- -D warningsonconnector(incl. tests) andcoreroot_store_contains_webpki_baselinetest inbackend/core/src/http.rsgradient loginagainst a self-hosted instance with a self-signed CA installed in the OS trust store should succeed withouttransport error