Merged
Conversation
Collaborator
Author
|
In the end the numba functions were removed altogether - they no longer seem to provide any performance improvement compared to the numpy equivalents. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numba is used to increase performance of some spectral statistics that require indexing from the spectral peak which cannot be done in dask. However numba usually pins numpy which can cause some issues. In addition, it is coupled at some level to the CPU architecture through LLVM so it has the potential cause errors on some hardware.
This pull request makes numba an optional dependency which is installed with the
extratag. The numba gufuncs are replaced by standard numpy functions if numba isn't installed which will have a compromise in terms of performance (noticeable when processing large datasets).