Merged
Conversation
Contributor
Author
|
@rafa-guedes, ready to be merged |
Collaborator
|
@RubendeBruin thanks for this pull request and sorry for taking ages to look at this, I'm finally having a look now and will get back to you |
Contributor
Author
|
Thanks @rafa-guedes ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reader adds functionality to read the NMEA data from an AWAC (Acoustic Waves And Current-profiler) device from https://www.nortekgroup.com/
The spectra are reconstructed from the Fourier coefficients using the maximum entropy method to remove negative energy.
Normalization is applied per frequency to keep energy over directions identical to energy in non-directional spectrum
The 2D spectral data is scaled to the significant wave height (Hs) given in the wave parameters.
The time is returned as read from the timestamps. The time-zone depends on the configuration of the device and is not included in the output.
Tests added to check the properties of the read 2D spectra against the integrated properties that are also reported in the NMEA string.