Reader and writer for Funwave file format#36
Merged
rafa-guedes merged 12 commits intomasterfrom May 29, 2021
Merged
Conversation
wavespectra/output/funwave.py
Outdated
| zip archive defined by replacing the extension of `filename` by ".zip". | ||
|
|
||
| """ | ||
| darr = self.efth.sortby(attrs.DIRNAME) |
Contributor
There was a problem hiding this comment.
Consider adding as a property:
spec.n_spectra
spec.is_oned
Collaborator
Author
|
@RubendeBruin what do you have in mind regarding these attributes? I guess |
Collaborator
Author
|
@RubendeBruin I added support to Funwave 1D reading / writing. It will deal naturally with that if the underlying dataset being written or file being read are 1D. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.