Skip to content

Fix NumPy error on pip install. Closes #74.#75

Merged
rafa-guedes merged 1 commit intowavespectra:masterfrom
cmichelenstrofer:numpy_pip
Oct 26, 2022
Merged

Fix NumPy error on pip install. Closes #74.#75
rafa-guedes merged 1 commit intowavespectra:masterfrom
cmichelenstrofer:numpy_pip

Conversation

@cmichelenstrofer
Copy link
Copy Markdown
Contributor

@cmichelenstrofer cmichelenstrofer commented Oct 26, 2022

This is how I tested it:

cd wavespectra
python3 -m venv .venv
. .venv/bin/activate
pip install .

This used to fail and now builds with no problem.

@rafa-guedes
Copy link
Copy Markdown
Collaborator

This is very useful @cmichelenstrofer thanks for that!

@rafa-guedes rafa-guedes merged commit 0ae569a into wavespectra:master Oct 26, 2022
@cmichelenstrofer
Copy link
Copy Markdown
Contributor Author

@rafa-guedes It would be great if the version on PyPi reflected this change. Maybe worth pushing a v3.12.1 so that pip install wavespectra works. Instead of waiting for the next big release.

@cmichelenstrofer cmichelenstrofer deleted the numpy_pip branch October 26, 2022 20:51
@rafa-guedes
Copy link
Copy Markdown
Collaborator

Version 3.12.1 has bee released, this will hopefully be available in conda as well soon.

rafa-guedes added a commit that referenced this pull request Jan 6, 2026
Fix NumPy error on pip install. Closes #74.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants