Skip to content

Fix task naming to avoid conflicts #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esimkowitz merged 1 commit into from
Oct 24, 2024
Merged

Fix task naming to avoid conflicts #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
tag: ${{github.ref_name}}
fileName: "*.snap"
- name: Publish to Snapcraft
run: "task artifacts:publish:snap:${{ github.ref_name }}"
run: "task artifacts:snap:publish:${{ github.ref_name }}"
env:
SNAPCRAFT_STORE_CREDENTIALS: "${{secrets.SNAPCRAFT_LOGIN_CREDS}}"
bump-winget:
Expand All @@ -44,8 +44,8 @@ jobs:
with:
version: 3.x
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Submit Winget version bump
run: "task artifacts:publish:winget:${{ github.ref_name }}"
- name: Submit WinGet version bump
run: "task artifacts:winget:publish:${{ github.ref_name }}"
env:
GITHUB_TOKEN: ${{ secrets.WINGET_BUMP_PAT }}
shell: pwsh
4 changes: 2 additions & 2 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ tasks:
echo "https://$SUFFIX"
fi
done
artifacts:publish:snap:*:
artifacts:snap:publish:*:
desc: Publishes the specified artifacts version to Snapcraft.
vars:
UP_VERSION: '{{ replace "v" "" (index .MATCH 0)}}'
Expand All @@ -239,7 +239,7 @@ tasks:
snapcraft upload --release={{.CHANNEL}} waveterm_{{.UP_VERSION}}_arm64.snap
snapcraft upload --release={{.CHANNEL}} waveterm_{{.UP_VERSION}}_amd64.snap

artifacts:publish:winget:*:
artifacts:winget:publish:*:
desc: Submits a version bump request to WinGet for the latest release.
status:
- exit {{if contains UP_VERSION "beta"}}0{{else}}1{{end}}
Expand Down