Skip to content

Rename "Default workspace" to "Starter workspace" #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esimkowitz merged 1 commit into from
Dec 6, 2024
Merged

Rename "Default workspace" to "Starter workspace" #1425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/wcore/wcore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import (

// TODO bring Tx infra into wcore

const DefaultTimeout = 2 * time.Second
const DefaultActivateBlockTimeout = 60 * time.Second
const StarterTimeout = 2 * time.Second
const StarterActivateBlockTimeout = 60 * time.Second

// Ensures that the initial data is present in the store, creates an initial window if needed
func EnsureInitialData() error {
Expand Down Expand Up @@ -58,16 +58,16 @@ func EnsureInitialData() error {
log.Println("client has windows")
return nil
}
log.Println("client has no windows, creating default workspace")
defaultWs, err := CreateWorkspace(ctx, "Default workspace", "circle", "green")
log.Println("client has no windows, creating starter workspace")
starterWs, err := CreateWorkspace(ctx, "Starter workspace", "circle", "green")
if err != nil {
return fmt.Errorf("error creating default workspace: %w", err)
return fmt.Errorf("error creating starter workspace: %w", err)
}
_, err = CreateTab(ctx, defaultWs.OID, "", true, true)
_, err = CreateTab(ctx, starterWs.OID, "", true, true)
if err != nil {
return fmt.Errorf("error creating tab: %w", err)
}
_, err = CreateWindow(ctx, nil, defaultWs.OID)
_, err = CreateWindow(ctx, nil, starterWs.OID)
if err != nil {
return fmt.Errorf("error creating window: %w", err)
}
Expand Down