Fix errors in loading of help view#1501
Merged
Merged
Conversation
xxyy2024
pushed a commit
to xxyy2024/waveterm_aipy
that referenced
this pull request
Jun 24, 2025
When clicking on one of the cards from the home page of the docsite and when initially loading the home page of the docsite, the webviewTag was emitting a `did-frame-navigate` event, which we weren't tracking. This meant that we were not properly recording that a navigation had occurred. This caused three separate issues: - We were never setting the meta url for the block, which meant that when you navigated to a different tab or reloaded the app, you'd lose what page you were last on. - The site would reload after we fixed a broken docsite url, but we wouldn't remove the error text that blocks the broken site. - Clicking on the "open in external browser" button wouldn't do anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking on one of the cards from the home page of the docsite and when initially loading the home page of the docsite, the webviewTag was emitting a
did-frame-navigateevent, which we weren't tracking. This meant that we were not properly recording that a navigation had occurred. This caused three separate issues: