Share tab badge rendering with vertical tabs#3034
Merged
Conversation
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Deploying waveterm with
|
| Latest commit: |
ae934b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://810ef855.waveterm.pages.dev |
| Branch Preview URL: | https://copilot-update-vtab-badge-di.waveterm.pages.dev |
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update badge display code in vtab component
Share tab badge rendering with vertical tabs
Mar 11, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
The PR correctly:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vertical tabs were still using the older single-badge path and did not honor the newer
tab:flagcolormetadata. This updatesvtabto use the same badge rendering model astab, including validated flag-color badges.Shared badge renderer
TabBadgesfromtab.tsxinto a sharedfrontend/app/tab/tabbadges.tsxcomponent.vtab.Vertical tab badge parity
badgeicon rendering invtab.tsxwithTabBadges.badgecallers and the newerbadgesarray shape.flagColorsupport invtabusing the samevalidateCssColor(...)guard astab.tsx, so invalid colors are ignored rather than rendered.Preview / regression coverage
vtabbarpreview to show:vtabcoverage for valid and invalidflagColorhandling.Example
Screenshot
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.