Skip to content

Final ticket updates#245

Merged
joshr4 merged 4 commits intomainfrom
final-ticket-updates
Mar 11, 2025
Merged

Final ticket updates#245
joshr4 merged 4 commits intomainfrom
final-ticket-updates

Conversation

@joshr4
Copy link
Collaborator

@joshr4 joshr4 commented Mar 11, 2025

Description by Korbit AI

What change is being made?

Update build number, replace the event description with ParsedTextWrapper, filter for future events only, modify RSVP success message, adjust payment confirmation text, remove specific event IDs to generalize logic, and refactor useZapEvent error handling.

Why are these changes being made?

To ensure version tracking, enhance the display of event descriptions, show only relevant events, clarify user communication post-purchase, streamline event handling, and improve error management for better maintainability and readability of the codebase.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Fix Detected
Functionality Missing null check for start timestamp ▹ view
Functionality Incorrect Event Image Logic ▹ view
Files scanned
File Path Reviewed
components/TicketEvents/EventListPage.tsx
components/TicketEvents/common.tsx
app.config.ts
components/TicketEvents/EventDetailPage.tsx
components/TicketEvents/EventRSVPPage.tsx
hooks/useZapEvent.ts

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Feedback and Support

...rest
}) => {
const isOllieEvent = eventId ? OLLIE_EVENTS.includes(eventId) : false;
const isOllieEvent = true;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect Event Image Logic category Functionality

Tell me more
What is the issue?

The isOllieEvent flag is now hardcoded to true, causing all events to display the Ollie show image regardless of the event type.

Why this matters

This will lead to incorrect image display for non-Ollie events, confusing users and misrepresenting event information.

Suggested change ∙ Feature Preview

Either implement proper logic to determine Ollie events or remove the special case entirely. If Ollie events are no longer special, simplify the image logic:

{image ? (
  <Image source={{ uri: image }} style={{ width: 80, height: 80 }} />
) : (
  <LogoIcon fill="white" width={37} height={31} />
)}

Report a problem with this comment

💬 Looking for more details? Reply to this comment to chat with Korbit.

Comment on lines +79 to +84
const futureEvents = eventList.filter((event) => {
const [startTag, startTimestamp] =
event.tags.find((tag) => tag[0] === "start") || [];
const timestamp = new Date(parseInt(startTimestamp) * 1000);
return timestamp > new Date();
});

This comment was marked as resolved.

@joshr4 joshr4 merged commit cd67454 into main Mar 11, 2025
@joshr4 joshr4 deleted the final-ticket-updates branch March 11, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant